-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
RenderCreation refactor #22714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
RenderCreation refactor #22714
Conversation
crates/bevy_render/src/lib.rs
Outdated
| .get_resource::<FutureRenderResources>() | ||
| .and_then(|frr| frr.0.try_lock().map(|locked| locked.is_some()).ok()) | ||
| .unwrap_or(true) | ||
| app.world().get_resource::<RenderResources>().is_some() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might not help, but I checked out your branch to see why the no_renderer example is failing, and I think it might have something to do with the ready function. If I change this to just return true, the example runs fine / I am able to close the window.
The previous ready seems to return true even if it wasn’t able to lock FutureRenderResources iiuc. I wonder if the example is able to progress because of that rather than progressing because RenderResources is Some
kfc35
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the easy-to-understand commit history; I shall be incorporating your technique in my own PR’s where appropriate 🍻
|
Doesn't work in wasm, either webgl2 or webgpu. |
Objective
Solution
Testing
note: reviewing by commit is easier. when a big block moves its just a copy paste, the minor tweaks are separated into other commits